From 6b0b51e390bb2cb76644f243d044a180c510700d Mon Sep 17 00:00:00 2001 From: Eric Davies Date: Fri, 2 Nov 2018 16:00:58 -0500 Subject: [PATCH 1/2] Stop type treason with show of the TrackedArray type --- src/tracker/lib/array.jl | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/tracker/lib/array.jl b/src/tracker/lib/array.jl index 432244ce..29cabdfb 100644 --- a/src/tracker/lib/array.jl +++ b/src/tracker/lib/array.jl @@ -33,9 +33,6 @@ TrackedArray(x::AbstractArray) = TrackedArray(Call(), x, zero(x)) Base.eltype(x::Type{<:TrackedArray{T}}) where T <: Real = TrackedReal{T} -Base.show(io::IO, ::Type{TrackedArray{T,N,A}}) where {T,N,A<:AbstractArray{T,N}} = - print(io, "TrackedArray{…,$A}") - function Base.summary(io::IO, x::TrackedArray) print(io, "Tracked ") summary(io, data(x)) From 4763473079c613ae466d1db0dc76b99a6de2e95c Mon Sep 17 00:00:00 2001 From: Mike J Innes Date: Tue, 6 Nov 2018 11:50:04 +0000 Subject: [PATCH 2/2] fixed method --- src/tracker/lib/array.jl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/tracker/lib/array.jl b/src/tracker/lib/array.jl index 29cabdfb..c1d65427 100644 --- a/src/tracker/lib/array.jl +++ b/src/tracker/lib/array.jl @@ -33,6 +33,11 @@ TrackedArray(x::AbstractArray) = TrackedArray(Call(), x, zero(x)) Base.eltype(x::Type{<:TrackedArray{T}}) where T <: Real = TrackedReal{T} +Base.show(io::IO, t::Type{TrackedArray{T,N,A}}) where {T,N,A<:AbstractArray{T,N}} = + @isdefined(A) ? + print(io, "TrackedArray{…,$A}") : + invoke(show, Tuple{IO,DataType}, io, t) + function Base.summary(io::IO, x::TrackedArray) print(io, "Tracked ") summary(io, data(x))