From c035fe22d7012d2d3b0c236513a2a20cea63a8e9 Mon Sep 17 00:00:00 2001
From: Dhairya Gandhi <dhairya@juliacopmuting.com>
Date: Fri, 24 Aug 2018 13:08:03 +0530
Subject: [PATCH] added deprecation warning

---
 src/optimise/Optimise.jl | 2 +-
 src/optimise/train.jl    | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/optimise/Optimise.jl b/src/optimise/Optimise.jl
index c4828c9e..9c7fd605 100644
--- a/src/optimise/Optimise.jl
+++ b/src/optimise/Optimise.jl
@@ -20,4 +20,4 @@ using Flux.Tracker: TrackedArray
 Param(x::TrackedArray) = Param(x.data, x.grad)
 # Base.convert(::Type{Param}, x::TrackedArray) = Param(x.data, x.grad)
 
-end
+end
\ No newline at end of file
diff --git a/src/optimise/train.jl b/src/optimise/train.jl
index 007613b6..06c8cd0e 100644
--- a/src/optimise/train.jl
+++ b/src/optimise/train.jl
@@ -1,5 +1,6 @@
 using Juno
 using Flux.Tracker: back!
+import Base.depwarn
 
 runall(f) = f
 runall(fs::AbstractVector) = () -> foreach(call, fs)
@@ -59,7 +60,10 @@ function train!(loss, data, opt; cb = () -> ())
       l = loss(d...)
       @interrupts back!(l)
       opt()
-      cb() == :stop && break
+      if cb() == :stop
+        depwarn("Use of `:stop` is deprecated; use `Flux.stop()` instead", :stop)
+        break
+      end
     catch ex
       if ex isa StopException
         break