From 8afed013458cf3f064f6be8f0e9427f49e1bade3 Mon Sep 17 00:00:00 2001 From: Adarsh Kumar <45385384+AdarshKumar712@users.noreply.github.com> Date: Thu, 27 Feb 2020 23:23:53 +0530 Subject: [PATCH] Apply suggestions from code review Co-Authored-By: David Lung --- src/layers/stateless.jl | 2 +- test/layers/stateless.jl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/layers/stateless.jl b/src/layers/stateless.jl index b4e97660..f05f19fc 100644 --- a/src/layers/stateless.jl +++ b/src/layers/stateless.jl @@ -79,8 +79,8 @@ function huber_loss(ŷ, y,delta=1.0) hub_loss+=delta*(abs_error[i]- dtype(0.5*delta)) end - return hub_loss*1//length(y) end + hub_loss*1//length(y) end diff --git a/test/layers/stateless.jl b/test/layers/stateless.jl index b7d15634..c09d1aae 100644 --- a/test/layers/stateless.jl +++ b/test/layers/stateless.jl @@ -18,7 +18,7 @@ const ϵ = 1e-7 end @testset "huber_loss" begin - @test Flux.huber_loss(ŷ, y) ≈ 0.0012499999999999994 + @test Flux.huber_loss(ŷ, y) ≈ 0.20500000000000002 end y = [123.0,456.0,789.0]