TastyPancakes
/
Flux.jl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix Glorot initialization 

Should fix #442
This commit is contained in:
Troels Arnfred Bojesen 2019-11-20 13:20:42 +09:00
parent 2b80573248
commit af96a197c1
2 changed files with 1 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/utils.jl
View File

@ -7,9 +7,6 @@ nfan(dims...) = prod(dims[1:end-2]) .* (dims[end-1], dims[end]) #In case of conv
glorot_uniform(dims...) = (rand(Float32, dims...) .- 0.5f0) .* sqrt(24.0f0 / sum(nfan(dims...)))
glorot_normal(dims...) = randn(Float32, dims...) .* sqrt(2.0f0 / sum(nfan(dims...)))
he_uniform(dims...) = (rand(Float32, dims...) .- 0.5f0) .* sqrt(24.0f0 / last(nfan(dims...)))
he_normal(dims...) = randn(Float32, dims...) .* sqrt(2.0f0 / last(nfan(dims...)))
ones(T::Type, dims...) = Base.ones(T, dims...)
zeros(T::Type, dims...) = Base.zeros(T, dims...)

15
test/utils.jl
View File

@ -1,6 +1,5 @@
using Flux
using Flux: throttle, nfan, glorot_uniform, glorot_normal, he_uniform, he_normal,
stack, unstack
using Flux: throttle, nfan, glorot_uniform, glorot_normal, stack, unstack
using StatsBase: var
using Random
using Test
@ -78,18 +77,6 @@ end
end
end
end
@testset "he" begin
# he_uniform and he_normal should both yield a kernel with variance ≈ 2/fan_in
for dims ∈ [(1000,), (100, 100), (100, 400), (2, 3, 32, 64), (2, 3, 4, 32, 64)]
for init ∈ [he_uniform, he_normal]
v = init(dims...)
fan_in, fan_out = nfan(dims...)
σ2 = 2 / fan_out
@test 0.9σ2 < var(v) < 1.1σ2
end
end
end
end
@testset "Params" begin