From 315101978be706ec1bad9aff2f852e54fce40e3c Mon Sep 17 00:00:00 2001
From: Chris de Graaf <chris.de.graaf@invenia.ca>
Date: Mon, 14 Aug 2017 13:59:33 -0500
Subject: [PATCH] Unbind plugin parameter in badges

---
 src/plugins/appveyor.jl    |  6 +++---
 src/plugins/codecov.jl     | 10 +++++-----
 src/plugins/githubpages.jl |  6 +++---
 src/plugins/travis.jl      |  6 +++---
 4 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/plugins/appveyor.jl b/src/plugins/appveyor.jl
index 5739d46..d387678 100644
--- a/src/plugins/appveyor.jl
+++ b/src/plugins/appveyor.jl
@@ -25,18 +25,18 @@ Add AppVeyor to a template's plugins to add AppVeyor CI support.
 end
 
 """
-    badges(plugin::AppVeyor, pkg_name::AbstractString, t::Template) -> Vector{String}
+    badges(\_::AppVeyor, pkg_name::AbstractString, t::Template) -> Vector{String}
 
 Generate Markdown badges for the current package.
 
 # Arguments
-* `plugin::AppVeyor`: Plugin whose badges we are generating.
+* `_::AppVeyor`: Plugin whose badges we are generating.
 * `t::Template`: Template configuration options.
 * `pkg_name::AbstractString`: Name of the package.
 
 Returns an array of Markdown badges.
 """
-function badges(plugin::AppVeyor, t::Template, pkg_name::AbstractString)
+function badges(_::AppVeyor, t::Template, pkg_name::AbstractString)
     user = strip(URI(t.remote_prefix).path, '/')
     return [
         "[![Build status](https://ci.appveyor.com/api/projects/status/github/$user/$pkg_name.jl?svg=true)](https://ci.appveyor.com/project/$user/$pkg_name-jl)"
diff --git a/src/plugins/codecov.jl b/src/plugins/codecov.jl
index 28dfac8..f3084c1 100644
--- a/src/plugins/codecov.jl
+++ b/src/plugins/codecov.jl
@@ -9,9 +9,9 @@ Add CodeCov to a template's plugins to enable CodeCov coverage reports.
 """
 @auto_hash_equals struct CodeCov <: Plugin
     gitignore_files::Vector{AbstractString}
-    config_file::AbstractString
+    config_file::Union{AbstractString, Void}
 
-    function CodeCov(; config_file::AbstractString="")
+    function CodeCov(; config_file::Union{AbstractString, Void}="")
         if config_file != nothing
             if isempty(config_file)
                 config_file = joinpath(DEFAULTS_DIR, "codecov.yml")
@@ -25,18 +25,18 @@ Add CodeCov to a template's plugins to enable CodeCov coverage reports.
 end
 
 """
-    badges(plugin::CodeCov, pkg_name::AbstractString, t::Template) -> Vector{String}
+    badges(\_::CodeCov, pkg_name::AbstractString, t::Template) -> Vector{String}
 
 Generate Markdown badges for the current package.
 
 # Arguments
-* `plugin::CodeCov`: plugin whose badges we are generating.
+* `_::CodeCov`: plugin whose badges we are generating.
 * `t::Template`: Template configuration options.
 * `pkg_name::AbstractString`: Name of the package.
 
 Returns an array of Markdown badges.
 """
-function badges(plugin::CodeCov, t::Template, pkg_name::AbstractString)
+function badges(_::CodeCov, t::Template, pkg_name::AbstractString)
     user = strip(URI(t.remote_prefix).path, '/')
     return [
         "[![codecov](https://codecov.io/gh/$user/$pkg_name.jl/branch/master/graph/badge.svg)](https://codecov.io/gh/$user/$pkg_name.jl)"
diff --git a/src/plugins/githubpages.jl b/src/plugins/githubpages.jl
index 3e95628..2ad6ec3 100644
--- a/src/plugins/githubpages.jl
+++ b/src/plugins/githubpages.jl
@@ -22,18 +22,18 @@ Add GitHubPages to a template's plugins to add Documenter.jl support via GitHub
 end
 
 """
-    badges(plugin::GitHubPages, pkg_name::AbstractString, t::Template) -> Vector{String}
+    badges(\_::GitHubPages, pkg_name::AbstractString, t::Template) -> Vector{String}
 
 Generate Markdown badges for the current package.
 
 # Arguments
-* `plugin::GitHubPages`: plugin whose badges we are generating.
+* `_::GitHubPages`: plugin whose badges we are generating.
 * `t::Template`: Template configuration options.
 * `pkg_name::AbstractString`: Name of the package.
 
 Returns an array of Markdown badges.
 """
-function badges(plugin::GitHubPages, t::Template, pkg_name::AbstractString)
+function badges(_::GitHubPages, t::Template, pkg_name::AbstractString)
     if haskey(t.plugins, TravisCI)
         user = strip(URI(t.remote_prefix).path, '/')
         return [
diff --git a/src/plugins/travis.jl b/src/plugins/travis.jl
index 1ecdbf5..b48c406 100644
--- a/src/plugins/travis.jl
+++ b/src/plugins/travis.jl
@@ -25,18 +25,18 @@ Add TravisCI to a template's plugins to add Travis CI support.
 end
 
 """
-    badges(plugin::TravisCI, pkg_name::AbstractString, t::Template) -> Vector{String}
+    badges(\_::TravisCI, pkg_name::AbstractString, t::Template) -> Vector{String}
 
 Generate Markdown badges for the current package.
 
 # Arguments
-* `plugin::TravisCI`: plugin whose badges we are generating.
+* `_::TravisCI`: plugin whose badges we are generating.
 * `t::Template`: Template configuration and plugins.
 * `pkg_name::AbstractString`: Name of the package.
 
 Returns an array of Markdown badges.
 """
-function badges(plugin::TravisCI, t::Template, pkg_name::AbstractString)
+function badges(_::TravisCI, t::Template, pkg_name::AbstractString)
     user = strip(URI(t.remote_prefix).path, '/')
     return [
         "[![Build Status](https://travis-ci.org/$user/$pkg_name.jl.svg?branch=master)](https://travis-ci.org/$user/$pkg_name.jl)"