From fa1b66bb365d6756d08e62273b32c4db54632c50 Mon Sep 17 00:00:00 2001 From: Chris de Graaf Date: Fri, 6 Oct 2017 14:08:35 +0100 Subject: [PATCH] Skip more problematic tests on OSX --- test/interactive/interactive.jl | 3 +++ test/interactive/plugins.jl | 2 ++ test/tests.jl | 6 +++--- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/test/interactive/interactive.jl b/test/interactive/interactive.jl index ed13f22..a5c23ce 100644 --- a/test/interactive/interactive.jl +++ b/test/interactive/interactive.jl @@ -2,6 +2,9 @@ # which seems to be the case in Travis CI OSX builds. # https://travis-ci.org/invenia/PkgTemplates.jl/jobs/267682403#L115 # https://github.com/nick-paul/TerminalMenus.jl/issues/5 +# This also affects any time we write to STDIN.buffer, because +# IOStreams do not have that attribute. +# Therefore, we skip any interactive tests on OSX builds. @testset "Interactive template creation" begin write(STDIN.buffer, "$me\n\n\r\n\n\n\n\nd") diff --git a/test/interactive/plugins.jl b/test/interactive/plugins.jl index 7ce894a..5185f43 100644 --- a/test/interactive/plugins.jl +++ b/test/interactive/plugins.jl @@ -1,3 +1,5 @@ +# These tests are to be skipped in OSX builds, see ./interactive.jl for more info. + @testset "TravisCI" begin write(STDIN.buffer, "\n") p = interactive(TravisCI) diff --git a/test/tests.jl b/test/tests.jl index 844a81a..8063578 100644 --- a/test/tests.jl +++ b/test/tests.jl @@ -118,12 +118,12 @@ end if get(ENV, "TRAVIS_OS_NAME", "") != "osx" include(joinpath("interactive", "interactive.jl")) + @testset "Interactive plugin creation" begin + include(joinpath("interactive", "plugins.jl")) + end else info("Skipping tests that require TerminalMenus") end -@testset "Interactive plugin creation" begin - include(joinpath("interactive", "plugins.jl")) -end @testset "File generation" begin